Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get and set ignored classes #2091

Merged
merged 4 commits into from Apr 17, 2020
Merged

get and set ignored classes #2091

merged 4 commits into from Apr 17, 2020

Conversation

wickedOne
Copy link
Contributor

allow ignored classes to be set in the rest action reader

fixes #2090

@wickedOne wickedOne mentioned this pull request Feb 11, 2020
Closed
Tobion
Tobion reviewed Feb 12, 2020
View reviewed changes
Routing/Loader/Reader/RestActionReader.php Outdated
*
* @return array
*/
public function getIgnoredClasses()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add return type

@xabbuh xabbuh added this to the 2.8 milestone Mar 28, 2020
Tobion
Tobion approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@Tobion Tobion left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good enough for me as it will be deprecated anyway. It fixes #2090 and #2078. Should be merged in 2.x.

@Tobion
Copy link
Member

Tobion commented Apr 10, 2020

@wickedOne could you change the target to 2.x and rebase? Currently there is a conflict.

@wickedOne
get and set ignored classes
7db8e76 
allow ignored classes to be set in the rest action reader

fixes FriendsOfSymfony#2090
@wickedOne
documented getter and setter
77f9a0d 
added return types and a little documentation for ignored classes
@wickedOne
fixed type hinting
d85dc37 
changed array type hints to be more explicit
@wickedOne wickedOne changed the base branch from master to 2.x April 10, 2020 14:42
@wickedOne
Copy link
Contributor Author

rebased and changed the target.

@wickedOne
remove constructor docblock
0c68b10 
fixing a rebase mishap
@Tobion Tobion merged commit 6a730f6 into FriendsOfSymfony:2.x Apr 17, 2020
@Tobion Tobion mentioned this pull request Apr 17, 2020
Closed
@wickedOne wickedOne deleted the ignored-classes branch April 17, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@Tobion Tobion Tobion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

RestActionReader ignoring user interface in 2.7.0
3 participants
@wickedOne @Tobion @xabbuh